[flashrom] [2/2] Add support for GD25D05B and GD25D10B

sean boree seanboree at gmail.com
Wed Mar 30 19:53:41 CEST 2016


Hello Hatim,

I have checked your patch; I only have one small remark (and I might be
very wrong on this, but I felt it best to discuss).

1 You use spi_prettyprint_status_register_bp2_srwd for both devices,
however this function also prints the bits 5, 6 (with
spi_prettyprint_status_register_bit). The datasheets of GD25D05B and
GD25D10B note that these bits are reserved. So I think either they should
not be used (thus different print function) or it should be noted somewhere
that these are reserved bits.

Acked-by: Sean Boree <seanboree at gmail.com>

> Hatim Kanchwala <hatim at hatimak.me> - 2016-03-16 15:39:23
> Signed-off-by: Hatim Kanchwala <hatim at hatimak.me>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20160330/2a6d1e92/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2-2-Add-support-for-GD25D05B-and-GD25D10B.patch
Type: text/x-patch
Size: 4936 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20160330/2a6d1e92/attachment.patch>


More information about the flashrom mailing list