[flashrom] [v3,2/2] ENE KB9012 EC flashrom patch - Bug report

[John Brown]

Good day! I applied your most recent KB9012 flashrom patch to the latest
flashrom copy, and tried to compile it for testing with my KB9012 chip.
However, I have encountered the following error:

flashchips.c:3209:19: error: 'FEATURE_ERASED_ZERO' undeclared here (not in
a function)
   .feature_bits = FEATURE_ERASED_ZERO,
                   ^
make: *** [flashchips.o] Error 1

FEATURE_ERASED_ZERO is not declared anywhere, neither in latest flashrom
revisions, nor in older flashrom revisions. Dont know why nobody noticed
this problem before me...

Then, I thought it could be a good idea to replace this undeclared value
with zero:
   .feature_bits = 0,

Flashrom compiled successfully after this change, but unfortunately it
cannot properly detect KB9012 chip that is attached to Bus Pirate through
KB9012 adapter. Important log part is attached below (interesting, why it
has not printed RDID stuff while probing for ENE KB9012)

...
Probing for Atmel AT45DB642D, 8192 kB: RDID byte 0 parity violation.
probe_spi_rdid_generic: id1 0xff, id2 0xffff
Probing for ENE KB9012 (EDI), 128 kB: Probing for ESMT F25L008A, 1024 kB:
RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0xff, id2 0xffff
Probing for ESMT F25L32PA, 4096 kB: RDID byte 0 parity violation.
probe_spi_rdid_generic: id1 0xff, id2 0xffff
...
Probing for Generic unknown SPI chip (REMS), 0 kB: probe_spi_rems: id1
0x7f, id2 0xff
Found Generic flash chip "unknown SPI chip (REMS)" (0 kB, SPI) on
buspirate_spi.
Found Generic flash chip "unknown SPI chip (REMS)" (0 kB, SPI).
===
This flash part has status NOT WORKING for operations: PROBE READ ERASE
WRITE
The test status of this chip may have been updated in the latest development
version of flashrom. If you are running the latest development version,
please email a report to flashrom at flashrom.org if any of the above
operations
work correctly for you with this flash chip. Please include the flashrom log
file for all operations you tested (see the man page for details), and
mention
which mainboard or programmer you tested in the subject line.
Thanks for your help!
Read is not working on this chip. Continuing anyway.
flashrom has no read function for this flash chip.
Aborting.
Raw bitbang mode version 1
Bus Pirate shutdown completed.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20160130/1b01e9cc/attachment.html>