[flashrom] [PATCH 2/2] Set LC_ALL globally in Makefile.

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Jan 10 15:09:39 CET 2016


On 08.01.2016 10:43, Stefan Tauner wrote:
> On Thu,  7 Jan 2016 19:22:41 +0100
> Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at> wrote:
>
>> While we're at it, comment and simplify the debug_shell function as well.
>>
>> Signed-off-by: Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>
>> ---
>>  Makefile | 11 ++++++++---
>>  1 file changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 757f3a8..6ddca58 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -77,8 +77,13 @@ PKG_CONFIG += --static
>>  LDFLAGS += -static
>>  endif
>>  
>> +LC_ALL=C
>> +export LC_ALL
>> +
> Apparently this does only make LC_ALL visible in recipe commands but
> not globally/in shell functions, cf.
> http://stackoverflow.com/a/26518222/1905491
>
> However, maybe we should set it here anyway? I certainly would not hurt.

I'm for adding it, but with a comment that it doesn't work in shell
functions (including the debug_shell alias). Otherwise someone will do a
cleanup and we get fallout sometime later.

Regards,
Carl-Daniel




More information about the flashrom mailing list