[flashrom] [PATCH] Add support for GD25VQ21B, GD25VQ40C, GD25VQ80C and GD25VQ16C

Stefan Tauner stefan.tauner at alumni.tuwien.ac.at
Sat Feb 27 01:10:07 CET 2016

On Fri, 26 Feb 2016 15:52:40 -0800
David Hendricks <dhendrix at google.com> wrote:

> > +#define GIGADEVICE_GD25VQ21B   0x4212
> > +#define GIGADEVICE_GD25VQ41B   0x4213  /* Same as GD25VQ40C, can be distinguished by SFDP */  

> This comment should go in the .c file, above the model_id for the
> GD25VQ40C and GD25VQ41B.

The only real reason for having flashchips.h is having a nice
overview of IDs and relevant information thus that comment is perfectly
fine there - it would get lost in the shuffle in the .c file.
We have lots of similar comments in the .h file, most prominently the
one for the GIGADEVICE_GD25Q128 that the above was copied from ;)

Kind regards/Mit freundlichen Grüßen, Stefan Tauner

More information about the flashrom mailing list