[flashrom] [PATCH] Partial architecture support for alpha hppa m68k sh s390

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Feb 25 21:10:39 CET 2016


On 25.02.2016 21:04, Carl-Daniel Hailfinger wrote:
> On 25.02.2016 01:15, Stefan Tauner wrote:
>> On Wed, 24 Feb 2016 00:45:07 +0100
>> Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>>
>>>> New version: Add S390/S390x support.
>>>>
>>>> Only non-PCI non-rawaccess hardware is supported.
>>>>
>>>> No idea if it even compiles. I don't have hardware to test, it's a blind
>>>> port.
>>>>
>>>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>> FWIW, I have just managed to compile all of these with libusb1 +
>> -compat, libftdi1 theoretically libpci (not used actually) on the build
>> bot with dynamic linking (ill fix static linking on the currently
>> about a dozen failing configurations soonish).
>>
>> I have also verified the defines used to identify the new
>> architectures. I have not checked the assignments of make variables. If
>> you think this is enough to merge it then you may read this as an
>> acked-by.
> Thanks for the review! I'll gladly take that ack.
>
>
>>>> +# Disable all hardware related drivers on architectures with unknown raw access properties.
>> The phrase "hardware related drivers" has some great potential for
>> improvement ;)
> Fixed. New version.
>
> Only non-PCI non-rawaccess hardware is supported.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Referencing the informal ack above, this is
Acked-by: Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>
and committed in r1943.

Regards,
Carl-Daniel




More information about the flashrom mailing list