[flashrom] [PATCH] Makefile: fix overriding of make command line arguments.

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Feb 19 01:02:23 CET 2016

On 18.02.2016 22:19, Stefan Tauner wrote:
> Command line arguments given when executing make should not stop us
> from setting commonly user-configurable variables like CPPFLAGS or
> Without this patch 'make CPPFLAGS="-Ifail"' would fail to find
> libusb1 headers and abort.
> Add override statements where we append mandatory options to
> these variables to make (Debian) packagers more happy.
> Also, r1920 introduced some explicit calls to pkg-config instead of
> $(PKG_CONFIG). This patch corrects that as well.
> Signed-off-by: Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>

You missed one instance:
CFLAGS += -Wno-format

Even if compiling for DOS is probably not something where default
packaging is involved, it would make the whole *FLAGS thing more consistent.
Other than that, it's
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>


More information about the flashrom mailing list