[flashrom] [PATCH 1/3] 128 bytes write granularity support

[Paul Kocialkowski]

Hi Carl-Daniel,

Le dimanche 18 octobre 2015 à 20:58 +0200, Carl-Daniel Hailfinger a
écrit :
> On 18.10.2015 19:37, Paul Kocialkowski wrote:
> > I noticed that you have reworded the commit message: I usually do
> > not > use conjugated verbs in commit headline. Does this conflict
> > with >
> flashrom's guidelines?
> 
> No formal guidelines, but "128 bytes write granularity support" is
> missing a crucial piece of information: Was this a bugfix, a new
> feature
> or something you removed?
> The reworded commit message has that info.

Well, it does end with "support", which indicates that support for this
was introduced, so I don't think it was confusing.

I really see commit headlines as titles, not active phrases and would
like to keep my commits phrased this way.

Please let me know during patch review next time you find the commit
headline not precise enough.

Thanks!

-- 
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis
on freedom and privacy/security.

Website: https://www.replicant.us/
Blog: https://blog.replicant.us/
Wiki/tracker/forums: https://redmine.replicant.us/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20151022/5c795605/attachment.asc>