[flashrom] [PATCH] Rigorously check integrity of I/O stream data.

Stefan Tauner stefan.tauner at alumni.tuwien.ac.at
Sun Nov 22 18:36:13 CET 2015


On Sun, 22 Nov 2015 18:29:34 +0100
Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at> wrote:

> Nevertheless I think we should merge this patch ASAP.

Or maybe with a goto from the error state of fwrite to the fclose call
(skipping fflush and fsync if fwrite fails), because there is really
no benefit of doing these calls in that case - it even produces one more
error output when trying to fsync /dev/full... OTOH fsyncing often
fails on non-regular files (e.g. /dev/null) even though everything
works as intended... *sigh*

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list