[flashrom] [PATCH 0/3] The makefile is too simple - let's improve on that

Stefan Tauner stefan.tauner at alumni.tuwien.ac.at
Sun Nov 15 16:40:44 CET 2015


Hi,

the first patch comes from mrnuke who had to jump through some hoops to
get flashrom compile on newer fedora releases due to the removal of
the old libftdi.

The second patch deals with the numerous background jobs our makefile
does, e.g. to detect support for certain libraries. I was always annoyed
by the bad usability in that regard - we did not inform the user properly.
With the patch we separate the easy to read messages from the debugging
information in another file.
It also fixes some minor bugs I might have introduced previously, and
also highlights how bad we do some things... like expaning a make
variable that contains multiple shell invocations for *every* C file
we compile (still better than autotools).

The last one was the actual goal of the second patch... to simply enable
static linking of flashrom. But as always I was touching lots of other
stuff... that's what the second patch became and so this one is very
simply actually.

Stefan Tauner (3):
  Add support for libftdi1.
  Make make errors more less flashily.
  Add support for linking statically with CONFIG_STATIC=yes.

 Makefile | 139 ++++++++++++++++++++++++++++++++++++---------------------------
 1 file changed, 80 insertions(+), 59 deletions(-)

-- 
Kind regards, Stefan Tauner





More information about the flashrom mailing list