[flashrom] [PATCH] New GigaDevice chips

[Roman Titov]

Well, I think this could be the result of my inexperience with svn
(and git-svn).

So, here's my steps:
1. git svn clone -rHEAD (r1887, to be exact) flashrom-trunk (I have an
error, when I'm trying to make full git svn clone, looks like git bug
:/)
2. *code*
3. make 2 local commits
4. git format-patch, and it throw me 2 patches for 2 latest commits
not over current origin (and I think thats is the reason)
5. send patches to mailing list

My suggestions would be:
1. shallow copying broke smth (idea, that git svn could bond git stuff
to full svn history stuff came to me just right now)
2. formating 2 patches broke smth
3. both?


2015-03-09 8:24 GMT+10:00 Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>:
> On Fri, 06 Mar 2015 17:51:11 +1000
> Роман Титов <titovroman at gmail.com> wrote:
>
>> One with GigaDevice chips support
>
> Hi,
>
> the patch looks syntactically ok but does not apply *cleanly* with
> git-am. Against which revision did you create it? The git hash in the
> patch suggests that it is against r1886-r1888 but I tried that...
>
> Patching with patch instead of git-am works (thanks to some fuzzying),
> but I was wondering what was causing that...?
>
> --
> Kind regards/Mit freundlichen Grüßen, Stefan Tauner



-- 
С уважением,
Титов Роман