[flashrom] [PATCH 2/3] Add support for SPARC (maybe).
stefan.tauner at alumni.tuwien.ac.at
Mon Jan 26 09:38:45 CET 2015
On Sun, 25 Jan 2015 03:04:09 +0100
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
> On 19.01.2015 21:39, Stefan Tauner wrote:
> > Does (cross-)compile but is not run-tested.
> > Signed-off-by: Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>
> > Acked-by: Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>
> > ---
> > Makefile | 2 +-
> > hwaccess.h | 8 ++++++++
> > platform.h | 5 ++++-
> > 3 files changed, 13 insertions(+), 2 deletions(-)
> hwaccess.c needs to be patched as well. Specifically,
> static inline void sync_primitive(void)
> needs either a comment why sync_primitive is unneeded or a a code
> snippet with correct code.
> Not sure if I read
> correctly, but we may need
> __asm__ __volatile__("membar #StoreLoad":::"memory")
> Mh. That might not be needed if /dev/mem uses a special access mode
> which enforces memory access ordering in Sparc. Someone else with Sparc
> knowledge needs to check this.
> That said, the patch looks correct apart from the missing hwaccess.c
> stuff mentioned above.
I doubt that we will find something competent enough to answer that
quickly. What about adding the information above to hwaccess.c so that
it is available in-tree to everybody in case something does not work
without a memory barrier?
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
More information about the flashrom