[flashrom] [PATCH] ft2232_spi.c: use ftdi.h named constants instead of magic numbers

Stefan Tauner stefan.tauner at alumni.tuwien.ac.at
Sat Jan 24 16:24:36 CET 2015

Hello Antony,

thanks for your patch. It looks good in general, but there are still
some magic constants in the code:
- the initial values for cs_bits and pindir
- 0x11 to enable writes

I guess those can be obtained from the header as well?
Kind regards/Mit freundlichen Grüßen, Stefan Tauner

More information about the flashrom mailing list