[flashrom] [PATCH] Fix a number of problems in mstarddc_spi.c.

Alexandre Boeglin alex at boeglin.org
Wed Feb 18 23:50:49 CET 2015


Hello,

Le mercredi 18 février 2015 à 01:31, Stefan Tauner a écrit:
> Coverity has brought up the following problems:

Sorry, I wasn't aware that there were coverity reports for the project.

> This patch revamps the function in various ways to fix these issues and some
> other irritating bits.
> It reduces scopes of variables where possible, pushes the code towards our
> coding standards and introduces a label-based resource cleanup at the end.

I agree, this patch does make the code easier to read, in addition to
fixing my mistakes :)


Best regards,
Alex

-- 
Alexandre Boeglin
email: alex (at) boeglin (dot) org
jabber: alex (at) im (dot) boeglin (dot) org
website: http://boeglin.org/




More information about the flashrom mailing list