[flashrom] [coreboot] [PATCH 0/4] Libflashrom

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Aug 15 07:23:26 CEST 2015


Hi Łukasz,

yesterday I built this on a Ubuntu 14.04.3 (amd64) and tried to run it,
but the tool segfaulted before even showing its own window. On the
second try, it ran, but didn't handle a missing edid-decode well:
sh: 1: edid-decode: not found

Regards,
Carl-Daniel

On 14.08.2015 10:30, Łukasz Dmitrowski wrote:
> Hello,
>
> I improved and extended libflashrom patch, so I am posting it for a
> second review.
> I based on work of Nico Huber and Anton Kochkov. As Nico Huber's patch
> has been
> already sent some time ago I will send only Anton Kochkov's building
> and compilation
> fixes (thanks for sharing it with me) and my changes.
>
> Content:
> 1 / 4 - Fix libflashrom compilation (by Anton Kochkov)
> 2 / 4 - Fix libflashrom building (by Anton Kochkov)
> 3 / 4 - Added querying functions to libflashrom
> 4 / 4 - Added function which returns string list of multiple chips found
>
> I will be grateful for your opinions - it helps me to improve the patch.
>
> All this code you can also find here:
> https://github.com/lukaszdmitrowski/flashrom/tree/libflashrom
>
> Regards,
> Lukasz  Dmitrowski
>
>
>





More information about the flashrom mailing list