[flashrom] [PATCH] Support for S25FL127S
stefan.tauner at alumni.tuwien.ac.at
Sat Nov 29 21:03:26 CET 2014
On Mon, 24 Nov 2014 23:59:15 +0100 (CET)
Jernej Škrabec <jernej.skrabec at planet.si> wrote:
> I'm attaching a patch which adds support for Spansion S25FL127S flash chip in 64KiB and 256KiB mode. I also tested 64KiB mode with FT4232H Mini Module which works fine (please see attached logs).
thanks for your patch! Please note that before we can include your
patch you need to sign the Developer's Certificate of Origin by
stating so in the patch/email. We can not include your patch as is!
for details, thanks.
Apart from that the naming of the chip definitions does not make much
sense. The model number of the S25FL127S does not denote the sector
layout in any way (unlike other Spansion chips). It would be best to
write a custom probing function that checks for the flags in the
configuration register and alters struct flashchip accordingly (similar
to what we do for at45db chips).
But for now I would accept a simple suffix to the "S25FL127S" name and
propose S25FL127S-64kB and S25FL127S-256kB.
Also, the comment in the patch is not correct AFAICS. Quote from the
datasheet "A P4E command applied to a sector that is larger than
4 kbytes will not be executed and will not set the E_ERR status."
This contradicts the comment that states that a bit is changed.
There are some minor other things I'd like to change but I can make
these changes myself. Thank you very much for your effort. Please reply
with your sign-off so that I can integrate the patch soon.
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
More information about the flashrom