[flashrom] [PATCH][RFC] rewrite read/write/verify to support layout/region based operations

Stefan Tauner stefan.tauner at alumni.tuwien.ac.at
Sun Nov 2 14:07:19 CET 2014


On Sun, 12 Oct 2014 22:37:23 +0200
Alexander Couzens <lynxis at fe80.eu> wrote:

> Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
> ---
> Hi everyone,
> 
> I've rewritten read/write/verify functions to get romregions/layouts working in all cases.
> A write to a specific region required before a complete read of the chip.
> Because of this it wasn't possible to write to a specific region, when another region is locked (ME lockdown).
> And flashrom is faster now when writing to a rom region.

Hi,

we have discussed this patch in Prague already but I was actually
looking at it at last. It is a bit convoluted/big so maybe I have
overlooked something, but I have not seen anything my patch set does
not or worse than this. I'll rethink if your approach with the single
layout region when no explicit region is given could improve my
approach, thanks for that input. Apart from that I would rather improve
my patch set where deemed necessary... if you have any additional inputs
on my approach I'd love to hear them though!

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list