[flashrom] [PATCH] Add support for SST26VF064B

Wei Hu wei at arista.com
Tue May 6 23:24:43 CEST 2014


Stefan,

Thanks for your reply. Your patch looks good to me.

On Tue, May 6, 2014 at 1:55 PM, Stefan Tauner
<stefan.tauner at alumni.tuwien.ac.at> wrote:
>>
>> I know spi_disable_blockprotect_generic() is useless here, but I
>> thought it was a good idea to call the generic function first in
>> general? As a side effect of calling this function I'm sending WREN,
>> so I didn't send on explicitly.
>
> There is no "generic" function that always should be called. The
> spi_disable_blockprotect_generic() function is just generic in the
> sense that most unprotect schemes can be implemented with it by
> supplying the respective parameters.
> Also, the WREN command is only active for one matching operation, and
> in this case this is the WRSR command that immediately follows it
> within spi_write_status_register_flag(). So your version would not do
> what you expect.

Maybe you're right, but I was able to erase/write the chip with my patch.

>> What's OTP? I didn't see it in the datasheet. Why do you want that?
>
> One-time-programmable memory, it is noted on the front page of the
> datahsset and is explained in more detail in 5.27 "Program Security ID".
> If the flag FEATURE_OTP is set for a chip, we produce the following
> message:

Sorry for not seeing OTP. I opened the file in a PDF reader and was
able to find the keyword. I wasn't able to search for it in Firefox
for some reason.




More information about the flashrom mailing list