[flashrom] [PATCH 2/5] Move check_chip_supported() to cli_classic.c.

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Jun 11 01:46:31 CEST 2014


Am 09.06.2014 14:41 schrieb Stefan Tauner:
> This function clearly belongs to the command line interface and should
> therefore reside in cli_classic.c and not in flashrom.c.
>
> Signed-off-by: Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>

Except for the last msg_ in that function, how does this belong to the
command line? You'd want the same functionality and messages (save for
the last one) if you're using a GUI.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list