[flashrom] [PATCH] Fix handling of write protection at register space address +2.

Stefan Tauner stefan.tauner at alumni.tuwien.ac.at
Wed Dec 10 23:50:20 CET 2014


On Wed, 10 Dec 2014 21:24:27 +0400
Roman Lebedev <lebedev.ri at gmail.com> wrote:

> Invalid locking change 0xf8 requested at 0xb7323002! Please report a bug at
> flashrom at flashrom.org

Thanks for testing Roman!

Carl-Daniel, do you have any idea why we do the "new_bits & ~REG2_MASK"
in changelock_regspace2_block() in jedec.c at all?
It is essentially your code, c.f.
http://patchwork.coreboot.org/patch/3412/

I propose to use "(old ^ new) & ~REG2_MASK" instead, i.e. check if the
caller requests a change of bits not related to the write protection. I
guess that was your original intention anyway, is that correct?
-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list