[flashrom] [PATCH] Fix probe_jedec() with continuation bytes, add EN29LV640T and get rid of probe_en29lv640b().

Stefan Tauner stefan.tauner at alumni.tuwien.ac.at
Mon Aug 11 01:07:44 CEST 2014


On Mon, 11 Aug 2014 00:12:56 +0200
Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at> wrote:

> We forgot to shift the addresses for continuation bytes in r1840.
> Also, probe_en29lv640b() can easily be replaced with refined probe_jedec().
> Furthermore, add EN29LV640T which is the top boot sector-variant of
> EN29LV640B.
> 
> Signed-off-by: Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>
> ---
> 
> Rudolf, if you still have access to the bifferboard, I'd very welcome
> testing this patch on it. This would verify the change we did in r1840
> (+ its fix in this patch) + the refactoring as well.
> 
> I might look into the write function later too, but currently probing
> functions are my main focus.

Actually I don't see anything unusual in the datasheet regarding
writing either, where does it state that the chip has to be programmed
in 16b words even if BYTE# is low?. I am not 100% if jedec_probe needs a
refinement for shifted access too, but we should be able to get this
to work in any case without an extra function, Carl-Daniel, please
advice. :)

PS: I have removed probe_en29lv640b() locally which I forgot on the
posted patch.
-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list