[flashrom] [PATCH 2/3] Refine handling chips that exceed maximum programmer sizes.

Stefan Tauner stefan.tauner at alumni.tuwien.ac.at
Fri Aug 8 17:07:04 CEST 2014


On Fri, 8 Aug 2014 16:57:23 +0200
Daniele Forsi <dforsi at gmail.com> wrote:

> 2014-08-08 16:25 GMT+02:00 Stefan Tauner:
> 
> > --- a/cli_classic.c
> > +++ b/cli_classic.c
> > @@ -91,7 +91,6 @@ static int check_filename(char *filename, char *type)
> >
> >  int main(int argc, char *argv[])
> >  {
> > -       unsigned long size;
> >         /* Probe for up to three flash chips. */
> >         const struct flashchip *chip = NULL;
> >         struct flashctx flashes[6] = {{0}};
> 
> unrelated to this changeset, but the comment above should read "six
> flash chips" now
> 

Yes, I am aware of that but thanks for reporting!
Let's hope the whole array is gone soon ;)
I have added the comment change to my tested_stuff branch #22 already
just in case...

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list