[flashrom] [PATCH] ichspi: fix missing set_addr on erases and possible crossings of 256 B boundaries.

Stefan Tauner stefan.tauner at alumni.tuwien.ac.at
Wed Aug 6 01:29:20 CEST 2014


On Sun,  3 Aug 2014 04:36:02 +0200
Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at> wrote:

> Apparently the erase function did never set any address before issuing the
> erase commands. How could this ever work?
> Also, according to PCH documentation crossing 256 byte boundaries is invalid
> and may cause wraparound due to the flash chip's pages. Check for this on
> reads as well as writes.
> 
> Thanks to Vladimir 'φ-coder/phcoder' Serbinenko for noticing these issues
> and providing the initial patch.
> 
> Signed-off-by: Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>
> Acked-by: Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>

Committed in r1837. Thanks again, phcoder!

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list