[flashrom] [PATCH] Added support for automatic uploading of log files
michael.n.coppola at gmail.com
Tue Apr 29 17:51:11 CEST 2014
On 04/27/2014 12:17 AM, Stefan Tauner wrote:
> On Wed, 26 Mar 2014 20:30:24 -0400
> Michael Coppola <michael.n.coppola at gmail.com> wrote:
>> Picked off "Add automatic uploading of log files" from the easy projects
>> wiki. Right now it requires the -o option to log to file, and then
>> uploads the log file contents to the pastebin. It's possible to bypass
>> this step and just maintain the log in memory, but it felt weird keeping
>> a constantly reallocating heap buffer of possibly infinite size.
>> Did some minimal testing and it seems to be working okay.
>> Signed-off-by: Michael Coppola <michael.n.coppola at gmail.com>
> Hi Michael,
> thanks a lot for your patch! You are right about the memory buffer, and
> I'd like to always output a log file (in a temporary location) anyway in
> the future. Unfortunately Carl-Daniel does not really like the idea at
> all... so we'll have to convince him over time of the patch's
> usefulness and it won't be committed soonish.
Sorry to hear that, hopefully it will be reconsidered in the future.
More information about the flashrom