[flashrom] [PATCH] CID1130007: Resource leak

Stefan Tauner stefan.tauner at alumni.tuwien.ac.at
Sat Apr 26 20:48:30 CEST 2014


On Tue, 19 Nov 2013 20:35:57 +0100
Stefan Reinauer <stefan.reinauer at coreboot.org> wrote:

> CID1130007: Resource leak
> 
> The system resource will not be reclaimed and reused, reducing the future
> availability of the resource.
> In ogp_spi_init: Leak of memory or pointers to system resources
> 
> Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
> 
> Index: ogp_spi.c
> ===================================================================
> --- ogp_spi.c	(revision 1763)
> +++ ogp_spi.c	(working copy)
> @@ -120,8 +120,10 @@
>  		ogp_reg_sck  = OGA1_XP10_CPROM_SCK;
>  	} else {
>  		msg_perr("Invalid or missing rom= parameter.\n");
> +		free(type);
>  		return 1;
>  	}
> +	free(type);
>  
>  	if (rget_io_perms())
>  		return 1;
> 

Acked-by: Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at>
and committed in r1774, thanks!

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list