[flashrom] [PATCH 0/2] layout patches 3.1 (first half)

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Thu Sep 19 01:29:36 CEST 2013

Apart from the unquoting disput and possible wording problems, I hope
this is closer to what we want. The removal of layout 1 parsing support
did not really remove much code...

I made a serious mistake when refining the whole patch set (and merged
a few patches in there sometime ago without noticing before reworking
a lot of stuff), so I hope I have cleaned that up correctly. If you
see code in there that seems to have nothing to do with the actual patch
then it is that - not insanity (neither on your nor my side).

The unquoting function is moved to helpers.c and gets used in the -i
patch already, because it makes sense there for really odd file
names. It might also make sense for ROM file or log file names, I
havent checked yet. Let's decide first if we want the function in
general and which features it should have before anything else please.

Finally, I refuse any responsibility for the new file exist check in
convert_layout_v1_to_v2.sh, that's carldani's fault alone I just
obeyed :P

Stefan Tauner (2):
  layout: Add -i <region>[:<file>] support.
  layout: Better file parsing.

 Makefile                        |   2 +-
 cli_classic.c                   |  15 +-
 dummyflasher.c                  |   2 +-
 flash.h                         |   6 +-
 flashrom.8.tmpl                 | 130 ++++++++------
 flashrom.c                      |  20 ++-
 helpers.c                       |  74 ++++++++
 layout.c                        | 367 ++++++++++++++++++++++++++++++++--------
 util/convert_layout_v1_to_v2.sh |  79 +++++++++
 9 files changed, 563 insertions(+), 132 deletions(-)
 create mode 100644 helpers.c
 create mode 100755 util/convert_layout_v1_to_v2.sh

Kind regards, Stefan Tauner

More information about the flashrom mailing list