[flashrom] [PATCH] Ensure DMI strings used in dmi_compare() are not NULL.

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Tue Oct 29 02:40:19 CET 2013


On Tue, 29 Oct 2013 00:12:50 +0100
Stefan Tauner <stefan.tauner at student.tuwien.ac.at> wrote:

> Previously the external DMI decoder did not allow this to happen because
> all possible pointers were initialized at startup by the output of
> 'dmidecode -s ...' which has default values for all supported types.
> 
> The now active internal DMI decoder does work differently: it scans the
> complete DMI table once and copies the available strings. Therefore, strings
> that are not set by the firmware are left at their default value of NULL.
> 
> Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>

Idwer reproduced the problem and was able to verify the correctness of
this patch (see new, extended commit log), hence
Acked-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
and committed in r1763.

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list