[flashrom] [PATCH] CID1130010: Resource leak

Stefan Reinauer stefan.reinauer at coreboot.org
Tue Nov 19 20:35:57 CET 2013


CID1130010: Resource leak

The system resource will not be reclaimed and reused, reducing the future
availability of the resource.
In verify_range: Leak of memory or pointers to system resources

Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Index: flashrom.c
===================================================================
--- flashrom.c	(revision 1763)
+++ flashrom.c	(working copy)
@@ -676,7 +676,8 @@
 
 	if (!flash->chip->read) {
 		msg_cerr("ERROR: flashrom has no read function for this flash chip.\n");
-		return 1;
+		ret = -1;
+		goto out_free;
 	}
 	if (!readbuf) {
 		msg_gerr("Could not allocate memory!\n");




More information about the flashrom mailing list