[flashrom] AMD - SP5100 - take SPI ownership (1/2)

Ward Vandewege ward at gnu.org
Fri May 24 20:54:58 CEST 2013


Hi all,

On Tue, May 07, 2013 at 02:14:47PM -0400, Ward Vandewege wrote:
> On Tue, Mar 26, 2013 at 04:36:25PM +0100, Rudolf Marek wrote:
> > I tried with IMC activated on coreboot (Hudson chipset) and it works
> > as expected. Attached patch only tweaks messages and removes now
> > redundant check from sb600 SPI. If IMC is active and firmware
> > handoff fails, then it exits with fatal error.
> 
> I've tested this patch against flashrom v0.9.6.1-r1673 on a Supermicro
> H8DGi-F board.
> 
> It works as expected. Without it, flashrom errors out complaining about SB600
> FIFO pointer corruption.
> 
> With your patch (http://patchwork.coreboot.org/patch/3894/), I was able to
> read *and* write the rom chip succesfully.

I've now also tested this patch (read, write, verify) on a Supermicro H8SCM
board. It works as expected, and without it, Flashrom is useless.

> > Signed-off-by: Rudolf Marek <r.marek at assembler.cz>
> 
> > It would be nice if someone else could test this (and dont forget to
> > be able to recover from bad flash)
> 
> Acked-by: Ward Vandewege <ward at gnu.org>

Can we please get this patch merged?

Thanks,
Ward.

-- 
Ward Vandewege             | CTO, Free Software Foundation
GPG Key: 25F774AB          | http://status.fsf.org/ward
http://fsf.org/blogs/RSS   | http://identi.ca/cure

Do you use free software? Donate to join the FSF and support freedom at
         http://www.fsf.org/register_form?referrer=859




More information about the flashrom mailing list