[flashrom] [PATCH 02/10] Add support for AMD Geode's MSR on OpenBSD.

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Sat Jul 13 23:25:42 CEST 2013

On Sat, 13 Jul 2013 17:36:28 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> Am 10.07.2013 21:17 schrieb Stefan Tauner:
> > Previously the default implementation was used, which always failed.
> > On other systems than the Geode the code is not equal to that anymore,
> > but should not explode because setup_cpu_msr() returns an error and
> > therefore no other MSR functions should be called.
> >
> > Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
> > Tested-by Leonardo Guardati <leonardo at guardati.it>
> > Acked-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
> >
> > Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
> Please kill one of your signoffs.

That was git send-mail i think... you can ignore that.

> I like the simplification of the previous #ifdef mess.
> Cosmetic suggestions (commit is OK without them as well):
> Move the libpayload setup_cpu_msr/cleanup_cpu_msr from the top of the
> file down to the block right after libpayload_wrmsr. This has the
> advantage of making the msr setup code for libpayload dependent on x86
> instead of having it enabled for all architectures.

As discussed... in 3/10.

> Add a comment to the OSX MSR functions which mentions that rdmsr/wrmsr
> are provided by DirectHW.
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Thanks, r1696.

Kind regards/Mit freundlichen Grüßen, Stefan Tauner

More information about the flashrom mailing list