[flashrom] [PATCH] Makefile: Warn if user tries to compile for libpayload w/o crossgcc.

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Thu Aug 29 03:05:46 CEST 2013


While flashrom is not as picky on compilers as coreboot, there is still a
high probablilty of breakage when one combines libpayload and distribution
compilers. Print a warning if we detect that to give the daring user a hint how
to resolve the explosions potentially following below it.

Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
---
 Makefile | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Makefile b/Makefile
index 70ef640..e000f4e 100644
--- a/Makefile
+++ b/Makefile
@@ -712,6 +712,11 @@ compiler: featuresavailable
 	@echo $(TARGET_OS)|wc -w|grep -q '^[[:blank:]]*1[[:blank:]]*$$' ||	\
 		( echo "unknown. Aborting."; exit 1)
 	@printf "%s\n" '$(TARGET_OS)'
+ifeq ($(TARGET_OS), libpayload)
+	@$(CC) --version 2>&1 | grep -q coreboot || \
+		( echo "Warning: It seems you are not using coreboot's reference compiler."; \
+		  echo "This might work but usually does not, please beware." )
+endif
 
 define LIBPCI_TEST
 /* Avoid a failing test due to libpci header symbol shadowing breakage */
-- 
Kind regards, Stefan Tauner





More information about the flashrom mailing list