[flashrom] MSR access fix on ALIX2D13 running OpenBSD-5.3

Leonardo Guardati leonardo at guardati.it
Wed Apr 17 12:01:01 CEST 2013

On Sat, Apr 13, 2013 at 01:49:54AM +0200, Stefan Tauner wrote:
> i'll post new patches in a minute (one corrected msr patch and an
> independent hwaccess.c patch that should fix netbsd hopefully and makes
> the defines more usable and sane and should be tested on openbsd too).
> i'd be very glad if you could test them on top of current HEAD again.

sorry for the delay, I've just checked out the last version of flashrom,
then I applied your 2 patches:
 -  http://patchwork.coreboot.org/patch/3936/ (hwaccess.c)
 -  http://patchwork.coreboot.org/patch/3937/ (physmap.c)

There is only a wrong member name to fix on physmap.c (line 415)
(the patch attached works with patch #3937 already applied)

After the fix the code works: I've tested the checksum of an already
flashed image, then wrote another image and checked again the checksum.

Thank You.


I confirm the OpenBSD msr probe failure is tinyBIOS related.
When the bios is coreboot, the probe is successfull.

-------------- next part --------------
--- physmap.c	2013-04-17 11:40:46.861911531 +0200
+++ physmap-fix.c	2013-04-17 11:46:07.169907130 +0200
@@ -413,7 +413,7 @@
 	struct amdmsr_req args;
-	args.msr = addr;
+	args.addr = (uint32_t)addr;
 	args.val = (((uint64_t)msr.hi) << 32) | msr.lo;
 	if (ioctl(fd_msr, WRMSR, &args) < 0) {

More information about the flashrom mailing list