[flashrom] [PATCH 1/3] Fix memleaks in dmi.c.

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Sun Sep 23 13:51:08 CEST 2012


On Sun, 23 Sep 2012 01:30:50 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> > +static int dmi_shutdown(void *data)
> > +{
> > +	int i;
> > +	for (i = 0; i < ARRAY_SIZE(dmistrings); i++) {
> > +		free(dmistrings[i]);  
> 
> libflashrom allows calling programmer_init() and programmer_shutdown()
> again after one flashrom run. For that case, we want the second run to
> have zeroed dmistrings[i]. Please insert
> dmistrings[i] = NULL;

IIRC i even had this in first. it is not necessary though because they
get overwritten by dmi_init() which gets called unconditionally by
internal_init(). i am not convinced, that it is a good idea to null
them anyway. note that the array is not initialized at startup either.

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list