[flashrom] [PATCH] Add support for AJAWe to pony_spi.

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Sat Sep 1 23:33:57 CEST 2012


On Sat, 1 Sep 2012 22:05:45 +0200
Virgil-Adrian Teaca <darkstarlinux at gmail.com> wrote:

> Ouch, you just found a bug in the detection code. :)
> 
> The right code (after my last thinking) is:
> 
>                  /* The AJAWe serial programmer just have DSR on when
> it is active. */
>                  data_in = sp_get_pin(PIN_DSR);
> 
>                  if(!data_in) {
>                          have_prog = 0;
>                  }

mhm :)

> > since we can not test or verify it otherwise, i will disable the
> > detection for now as posted. we can add it later if need be and we find
> > out how it really is supposed to work. thanks for looking at the
> > changes and your initial patch!
> 
> I totally agree with the disabling of AJAWe auto-detection until we
> figure out how it really works and IF really we need it.

ok then, thanks. i have committed my version in r1590.
-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list