[flashrom] [PATCH 1/3] Do not read the flash chip twice in verification mode.

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Oct 27 18:26:54 CEST 2012


Am 27.10.2012 17:38 schrieb Stefan Tauner:
> On Thu, 9 Aug 2012 01:01:30 +0200
> Stefan Tauner <stefan.tauner at student.tuwien.ac.at> wrote:
>
>>>> This introduces a small output change: previously we printed ERASE or
>>>> VERIFY depending on the callee. This special case has been dropped
>>>> because it is unnecessary to print it (and wrong for the verification
>>>> function to need to know why it is verifying exactly).
>>>> If an erase fails we mention that fact explicitly already, similar for verify.    
>>> I'm not convinced yet. I'll try to compare the failure output with and
>>> without this patch before I ack.  
> 1/4 year is too long.
> committed in r1619.

Point taken. Thanks for merging this.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list