[flashrom] [PATCH] Improve --help and friends.
Stefan Tauner
stefan.tauner at student.tuwien.ac.at
Sat Nov 24 20:02:20 CET 2012
On Sat, 24 Nov 2012 19:22:45 +0100
Paul Menzel <paulepanter at users.sourceforge.net> wrote:
> Am Samstag, den 24.11.2012, 18:44 +0100 schrieb Stefan Tauner:
> > More clear "variable" names, better explanation if now programmer is selected etc.
>
> s,now,no,
>
> > Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
> > ---
> > cli_classic.c | 78 +++++++++++++++++++++++++--------------------------------
> > flashrom.c | 1 -
> > print.c | 1 +
> > 3 files changed, 35 insertions(+), 45 deletions(-)
> >
> > diff --git a/cli_classic.c b/cli_classic.c
> > index ccf75e9..0d28d15 100644
> > --- a/cli_classic.c
> > +++ b/cli_classic.c
> > @@ -33,58 +33,42 @@
> >
> > static void cli_classic_usage(const char *name)
> > {
> > - printf("Usage: flashrom [-h|-R|-L|"
> > + printf("Please note that the command line interface for flashrom has changed between\n"
> > + "0.9.5 and 0.9.6 and will change again before flashrom 1.0.\n\n");
> > +
> > + printf("Usage: %s [-h|-R|-L|"
> > #if CONFIG_PRINT_WIKI == 1
> > - "-z|"
> > + "-z|"
>
> Indentation is changed?
yes, this was not according to our coding guidelines (not that it
improves anything here...)
> > #endif
>
> […]
>
> I quickly looked over it and could not find any suspicious. It is hard
> though as there are a lot of white space changes.
hence the pastes and discussions on IRC ;)
> Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>
Thanks, Carl-Daniel also agreed (with minor modifications) so i
committed it in r1624.
--
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
More information about the flashrom
mailing list