[flashrom] [PATCH] remove exit call from internal_init

David Hendricks dhendrix at google.com
Wed May 30 21:24:19 CEST 2012


This seems trivial, as internal_init() already does the right thing when a
return value is used here.

Acked-by: David Hendricks <dhendrix at google.com>

On Wed, May 30, 2012 at 11:48 AM, Niklas Söderlund <niso at kth.se> wrote:

> Replace with a return instead, all other plumbing is already in place
>
> Signed-off-by: Niklas Söderlund <niso at kth.se>
> ---
>  internal.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/internal.c b/internal.c
> index 5b24577..75e526b 100644
> --- a/internal.c
> +++ b/internal.c
> @@ -298,7 +298,7 @@ int internal_init(void)
>                        msg_perr("Proceeding anyway because user forced us
> to.\n");
>                } else {
>                        msg_perr("Aborting.\n");
> -                       exit(1);
> +                       return 1;
>                }
>        }
>
> --
> 1.7.10.2
>
>
> _______________________________________________
> flashrom mailing list
> flashrom at flashrom.org
> http://www.flashrom.org/mailman/listinfo/flashrom




-- 
David Hendricks (dhendrix)
Systems Software Engineer, Google Inc.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20120530/614afa56/attachment.html>


More information about the flashrom mailing list