[flashrom] Add chip Pm39LV512

Paul Menzel paulepanter at users.sourceforge.net
Sat May 19 21:50:21 CEST 2012


Dear Kyösti,


Am Samstag, den 19.05.2012, 22:09 +0300 schrieb Kyösti Mälkki:
> This flash is like PMC model Pm39LV010 but capacity is 64kB.

could you add a link to the data sheet to the commit message?

> Model ID was already defined, PREW works for me.

Could you also sent the output of `flashrom -Vr` and the other commends
to the list for archival purposes.

> Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
> 
> Index: flashrom-pmc64k/flashchips.c
> ===================================================================
> --- flashrom-pmc64k/flashchips.c	(revision 1538)
> +++ flashrom-pmc64k/flashchips.c	(working copy)
> @@ -5267,6 +5267,36 @@
>  
>  	{
>  		.vendor		= "PMC",
> +		.name		= "Pm39LV512",

If this list is sorted, it should go after »Pm39LV010«.

> +		.bustype	= BUS_PARALLEL,
> +		.manufacture_id	= PMC_ID_NOPREFIX,
> +		.model_id	= PMC_PM39LV512,
> +		.total_size	= 64,
> +		.page_size	= 4096,
> +		.feature_bits	= FEATURE_ADDR_2AA | FEATURE_EITHER_RESET,
> +		.tested		= TEST_OK_PREW,
> +		.probe		= probe_jedec,
> +		.probe_timing	= TIMING_ZERO,	/* Datasheet has no timing info specified */
> +		.block_erasers	=
> +		{
> +			{
> +				.eraseblocks = { {4 * 1024, 16} },
> +				.block_erase = erase_sector_jedec,
> +			}, {
> +				.eraseblocks = { {64 * 1024, 1} },
> +				.block_erase = erase_block_jedec,
> +			}, {
> +				.eraseblocks = { {64 * 1024, 1} },
> +				.block_erase = erase_chip_block_jedec,
> +			}
> +		},
> +		.write		= write_jedec_1,
> +		.read		= read_memmapped,
> +		.voltage	= {2700, 3600},
> +	},
> +
> +	{
> +		.vendor		= "PMC",
>  		.name		= "Pm39LV010",
>  		.bustype	= BUS_PARALLEL,
>  		.manufacture_id	= PMC_ID_NOPREFIX,

With the above comments addressed, you can add

    Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>

to the [PATCH v2].


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20120519/1be2a5d6/attachment.asc>


More information about the flashrom mailing list