[flashrom] [PATCH] Fix parallel-style programmer access from SPI

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Mar 1 09:09:40 CET 2012


Hi Johan,

thanks for testing!

Am 01.03.2012 08:21 schrieb Johan Svensson:
> Hello Carl-Daniel,
>
> It works perfectly well with this patch. No segfault, no new error message
> and the output file is populated with data.
>
> Thank you very much for awesome support!
>
> Johan

This would qualify the patch as tested, but is the style in which it
solves the problem (indirection via mmio_readn) the right way to do
this? Comments from a reviewer perspective appreciated.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list