[flashrom] [PATCH 1/7] Introduce and use enum test_state

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Jul 28 16:38:05 CEST 2012


Am 28.07.2012 16:30 schrieb Stefan Tauner:
> On Sat, 03 Mar 2012 23:32:23 +0100
> Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>
>> Is it possible that this patch made the board table one or two tabs
>> wider? The patch looks like that, and while I agree that some
>> files/sections should not have line length limits, adding another 16
>> columns of whitespace is something I'd like to avoid.
> in general the url is the source of length problem.
> does making the table longer by putting the URL in a line
> of its own make sense?

It's certainly a novel idea, and it has some appeal.


> i personally would drop the URL anyway.. useless, partially misleading
> (for boards with multiple variants) and work for me (only, as i must
> emphasize :)

Yes, now that Uwe is essentially a fulltime sigrok developer, he's not
maintaining that stuff anymore.
What do you think about asking someone else to do the tested_stuff
maintenance?

> iirc uwe was strongly against this, but i would be lying if would say
> that his matters much to me in this case (because the tested stuff
> branch is the most boring work i do for this project, not because i dont
> respect his view).

Back then the policy was accepted because he handled the board testing
maintenance. We might have to rethink this.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list