[flashrom] How to suffix similar-but-different parts?
stefan.tauner at student.tuwien.ac.at
Wed Jul 25 23:03:30 CEST 2012
On Wed, 25 Jul 2012 12:14:33 -0700
David Hendricks <dhendrix at google.com> wrote:
> There's a SPI chip named "N25Q064" with 1.8V and 3V variants N25Q064A11 and
> N25Q064A13, respectively. The 1.8V has A11 suffixed, and the 3V version has
> A13 suffixed. The 'A' indicates the process technology which is likely to
> change without a change of device ID, so it's likely that we'll see
> something like N25Q064B11 or N25Q064B13 in the future.
> Fortunately, the two variants have different JEDEC IDs (0xBA17 and 0xBB17).
> So at least we can tell them apart via probing.
> stefanct and I were discussing how to name this chip couldn't really come
> up with a good solution. I am thinking that "N25Q064" is sufficient and
> that we should just re-use the same .name for two chip entries with
> different .voltage parameters.
datasheets for the devices in question:
<dhendrix> 3V version: http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_64mb_3v_65nm.pdf
<dhendrix> 1.8V version: http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_64mb_1_8v_65nm.pdf
david: you dont give a rationale why you think that N25Q064 is enough.
my argumnt why it is not enough: the .name is used to distinguish
what flashrom defines as individual chips when presenting them to the
user. so it is not enough that flashrom can distinguish the chips by
their IDs but also the user must be able to tell the difference hence
there must be no duplicative names.
fwiw: i think we need a place holder for "any character" in model names
and propose "."
so in this case:
rationale: easily understandable, regex semantic, not part of actual
chip names, non-distracting.
alternatively we could just ignore that problem (it is a future problem
after all) and use N25Q064A11 and N25Q064A13.
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
More information about the flashrom