[flashrom] [PATCH] Add RDC R6030 chipset

[Stefan Tauner]

On Sun, 29 Jan 2012 00:16:55 +0100
Rudolf Marek <r.marek at assembler.cz> wrote:

> Hello,
> 
> Following patch adds the support for ROMCS_EN for writes aka chipset_enable on 
> RDC R6030 found on bifferboard.
> 
> The patch for flashchip will follow in near future.
> 
> Signed-off-by: Rudolf Marek <r.marek at assembler.cz>
> 

thanks rudolf for the patch.
the chipset/soc itself seems to be named R8610 afaics. i could not find
any references to R6030 as a model name. the pci id is 6030h though...
i would suggest changing the R6030 strings to R8610 if i am not
mistaken.

> Index: chipset_enable.c
> ===================================================================
> --- chipset_enable.c	(revision 1485)
> +++ chipset_enable.c	(working copy)
> @@ -54,6 +54,17 @@
>  	return 0;
>  }
>  
> +static int enable_flash_rdc(struct pci_dev *dev, const char *name)
please also add a suffix to the function name to indicate the model.

> +{
> +	uint8_t tmp;
> +
> +	tmp = pci_read_byte(dev, 0x43);
> +	tmp |= 0x80;
> +	pci_write_byte(dev, 0x43, tmp);
> +
> +	return 0;
> +}
> +
i have verified that this enables write cycles as you said. i am (still)
not familiar with LPC, but there must be a few other things that
are needed to get this chipset to work (at least in non-bifferboard
configurations)(?) and afaics we would also like to check a few other
things.

there is "FRS" which indicates the flash type boot strap, which could
also be X bus. guess X bus does not work transparently, does it?

what about the FRR (flash rom region) registers?

this does not registers a flashrom programmer!?

maybe i am just confused... :)


-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner