[flashrom] [RFC] Merging EC support from chromium trees
c-d.hailfinger.devel.2006 at gmx.net
Wed Jan 4 00:33:28 CET 2012
Am 03.01.2012 23:44 schrieb Stefan Tauner:
> On Tue, 03 Jan 2012 20:59:56 +0100
> Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>> The Linux kernel has a staging directory, I propose we use a similar
>> mechanism for flashrom (without the special staging/ directory, though):
>> Merge driver files as-is and clean them up in our tree, but have all
>> hooks for the staging code inside #ifdef EXPERIMENTAL or somesuch.
> *stand-alone* drivers could also be just disabled in the makefile by
> default. either way those are not a problem and i support your plan.
> i am not sure if other code that is more tightly integrated into
> other files as well can be dealt with appropriately with an #ifdef or
> if that would clutter the files too much. OTOH this might not be
> necessary... i guess we can discuss this in a review prior to
> inclusion... you dont plan to just drop them in i hope? :)
I hope David Hendricks will submit one patch for each hardware driver,
and then we can review each of them to get them into a semi-mergeable
shape and continue from there.
Compilation will be disabled by default (full drivers with makefile
hacks, hooks in other files with #
ifdef) until the code is ready for prime time.
More information about the flashrom