[flashrom] [PATCH] Add logfile support to flashrom

[Stefan Tauner]

On Wed, 04 Jan 2012 02:08:06 +0100
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> Oh well... new iteration, with some of the suggestions merged.
> This still is not final, but it should be a bit closer.
> 
> @@ -510,9 +541,13 @@
>  	 * Give the chip time to settle.
>  	 */
>  	programmer_delay(100000);
> -	return doit(fill_flash, force, filename, read_it, write_it, erase_it, verify_it);
> +	ret |= doit(fill_flash, force, filename, read_it, write_it, erase_it, verify_it);
>  
>  out_shutdown:
>  	programmer_shutdown();
> +out:

^ unused (hence breaking compilation)

> +#ifndef STANDALONE
> +	ret |= close_logfile();
> +#endif
>  	return ret;

also i see a little problem with this... ;)
./flashrom 
flashrom v0.9.4-r1483 on Linux 2.6.35-32-generic (x86_64)
flashrom is free software. Get the source code at http://www.flashrom.org

No filename specified.

attached is your patch rebased to r1490 without "out:"
maybe we can get this into 0.9.5 after some rework? do you have a todo
for it?
-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-logfile-support-to-flashrom.patch
Type: text/x-patch
Size: 16748 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20120209/6c8755f0/attachment.patch>