[flashrom] [PATCH] Explicitly store max write size (writers array)

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Wed Aug 29 17:32:23 CEST 2012


On Wed, 29 Aug 2012 09:19:51 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> This patch is not ready for merge, a few programmers will not compile
> because the conversion is unfinished.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> 
> Index: flashrom-max_write_size/flash.h
> ===================================================================
> --- flashrom-max_write_size/flash.h	(Revision 1587)
> +++ flashrom-max_write_size/flash.h	(Arbeitskopie)
> @@ -141,7 +141,10 @@
>  
>  	int (*printlock) (struct flashctx *flash);
>  	int (*unlock) (struct flashctx *flash);
> -	int (*write) (struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len);
> +	struct {
> +		int (*write) (struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len);
> +		int max_write_size;
> +	} writer;
>  	int (*read) (struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len);
>  	struct voltage {
>  		uint16_t min;

we could make this a writers array already like the erasers array, but
with a single entry only for now. while not required for this feature it
is clear that we will want to go that way in the future and imho it is
also clear that there wont be a single patch that adds all writers to
flashchips.c together with the implementation of the usage of this array
(i.e. the implementation patch will not touch flashchips.c at all, but
there will be one or more patches by steven for example that add those
entries ;)

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list