[flashrom] [PATCH 2/2] Add support for FT232HM
stefan.tauner at student.tuwien.ac.at
Mon Aug 27 06:03:31 CEST 2012
On Thu, 14 Jun 2012 18:07:59 +0300
"Ilya A. Volynets-Evenbakh" <ilya at total-knowledge.com> wrote:
> FT232HM is a USB to SPI/I2C/RSR232 converter, with USB on one
> end, and 10 separate single female pin headers on the other.
> Basically, it can be hooked up any way you want, and then configured
> This patch introduced support for following things:
> - FT232H chip
> - Support for two slaves on SPI bus (can be extended to
> 5 - the device has 4 GPIOs in addition to standard CS)
> - Added option to enable libusb debug output
hello Ilya and thanks for your patch!
i have not reviewed or tested your patch in detail but i have the
following change requests:
extract_programmer_param allocates a new string, so you need to clean
its return value up with free() (see other usages in the same file)
also, can you please split the patch up in at least two parts:
- general FT232H support
- support for multiple slaves (i would prefer if you could add the
other GPIOs too)
the first one can be merged without much concern (maybe some ifdefs to
be backward compatible to older libftdis). the CS/GPIO part needs
some internal discussion first, hence the requested split.
i am not sure if we want to merge the libusb debug part at all, but if
you want it please provide it as separate patch.
have you done some benchmarks? i'd like to know if this chip behaves
significantly different to the older ones.
> This patch requires latest libftdi sources from libftdi
> git tree, and consequently libusb >= 1.0
> Signed-off-by: Ilya A. Volynets-Evenbakh <ilya at total-knowledge.com>
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
More information about the flashrom