[flashrom] [PATCH 6/8] use getpagesize() to determine physmap's length in nicintel_spi.c

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Sun Aug 26 23:55:22 CEST 2012

On Thu, 31 Mar 2011 08:45:39 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> Am 15.03.2011 16:29 schrieb Stefan Tauner:
> > Signed-off-by: Stefan Tauner<stefan.tauner at student.tuwien.ac.at>
> >    
> Right, this is a really good idea.
> Could you patch physmap instead to round down the requested address and 
> round up the end of the range? Then we could just request the amount we 
> need without having to care in each programmer driver about page size.
> I think somewhere in flashrom we even have rounding code for physmap, it 
> just needs to be moved from a driver to the generic physmap.
> Your code looks solid.

Ooops, we forgot this one... more or less :)
committed in r1584

Kind regards/Mit freundlichen Grüßen, Stefan Tauner

More information about the flashrom mailing list