[flashrom] [PATCH] Make struct flashchip a field in struct flashctx instead of a complete copy.

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Mon Aug 20 00:54:39 CEST 2012

On Mon, 20 Aug 2012 00:39:19 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> >>  notfound:
> >> -		programmer_unmap_flash_region((void *)fill_flash->virtual_memory, size);
> >> +		programmer_unmap_flash_region((void *)flash->virtual_memory, size);
> >> +		flash->virtual_memory = (chipaddr)NULL;
> >> +		free(flash->chip);
> >> +		flash->chip = NULL;  
> > pretty clear indication that this function has issues imho :)  
> _Had_ issues. I really like the new code, because it not only
> frees/unmaps stuff, it also leaves no dangling pointers around.

in a function that should actually just probe for a chip. my definition
of code issues seems to be different. :)

but it got better, and it is certainly ready for merge.

i would prefer if you would take the bits of my patch that you like, add
them to your patch and then repost or commit right away.

Kind regards/Mit freundlichen Grüßen, Stefan Tauner

More information about the flashrom mailing list