[flashrom] [PATCH] Allow the user to specify CFLAGS without breaking the build

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Aug 14 23:37:48 CEST 2012

Am 13.08.2012 11:09 schrieb Stefan Tauner:
> On Mon, 13 Aug 2012 04:03:04 +0200
> Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>> Note: THIS WILL BREAK THE BUILD due to problems in the
>> ich_descriptors_tool code.
> pah! no idea what you are talking about! ;)

Thanks for fixing the code!

> is there a reason why we use CPPFLAGS instead of another name that is
> less likely to be used in the future? why not leave the CPPFLAGS
> variable alone and use a new one for the mandatory flags?

CPPFLAGS is the standard for preprocessor flags, and this is pretty much
exactly what we're trying to do.

>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> Acked-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>

Thanks, committed in r1574.



More information about the flashrom mailing list