[flashrom] [PATCH 1/3] Do not read the flash chip twice in verification mode.

[Stefan Tauner]

On Wed, 01 Aug 2012 01:20:01 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> > This introduces a small output change: previously we printed ERASE or
> > VERIFY depending on the callee. This special case has been dropped
> > because it is unnecessary to print it (and wrong for the verification
> > function to need to know why it is verifying exactly).
> > If an erase fails we mention that fact explicitly already, similar for verify.  
> 
> I'm not convinced yet. I'll try to compare the failure output with and
> without this patch before I ack.

maybe this helps :)

new non-verbose behavior:
Erasing and writing flash chip... FAILED at 0x00040000! Expected=0xff, Found=0x91, failed byte count from 0x00040000-0x00040fff: 0xff0
ERASE FAILED!
Reading current flash chip contents... done. Erase/write done.
Verifying flash... FAILED at 0x00010000! Expected=0x6b, Found=0x13, failed byte count from 0x00000000-0x0007ffff: 0x101
Your flash chip is in an unknown state.

old non-verbose behavior:
Erasing and writing flash chip... ERASE FAILED at 0x00040000! Expected=0xff, Read=0x9c, failed byte count from 0x00040000-0x00040fff: 0xfea
ERASE FAILED!
Reading current flash chip contents... done. Erase/write done.
Verifying flash... VERIFY FAILED at 0x00010000! Expected=0x11, Read=0x13, failed byte count from 0x00000000-0x0007ffff: 0xff
Your flash chip is in an unknown state.

new verbose:
Erasing and writing flash chip... Trying erase function 0... 0x000000-0x000fff:EW, 0x001000-0x001fff:EW, 0x002000-0x002fff:EW, 0x003000-0x003fff:EW, 0x004000-0x004fff:EW, 0x005000-0x005fff:EW,
[…]
0x03c000-0x03cfff:EW, 0x03d000-0x03dfff:EW, 0x03e000-0x03efff:EW, 0x03f000-0x03ffff:EW, 0x040000-0x040fff:EFAILED at 0x00040000! Expected=0xff, Found=0x9c, failed byte count from 0x00040000-0x00040fff: 0xfea
ERASE FAILED!
Reading current flash chip contents... done. Looking for another erase function.
Trying erase function 1... 0x000000-0x007fff:S, 0x008000-0x00ffff:S, 0x010000-0x017fff:S, 0x018000-0x01ffff:S, 0x020000-0x027fff:EW, 0x028000-0x02ffff:S, 0x030000-0x037fff:S, 0x038000-0x03ffff:S, 0x040000-0x047fff:EW, 0x048000-0x04ffff:EW, 0x050000-0x057fff:EW, 0x058000-0x05ffff:EW, 0x060000-0x067fff:EW, 0x068000-0x06ffff:EW, 0x070000-0x077fff:EW, 0x078000-0x07ffff:EW
Erase/write done.
Verifying flash... FAILED at 0x00010000! Expected=0x11, Found=0x13, failed byte count from 0x00000000-0x0007ffff: 0xff
Your flash chip is in an unknown state.

old verbose:
Erasing and writing flash chip... Trying erase function 0... 0x000000-0x000fff:EW, 0x001000-0x001fff:EW, 0x002000-0x002fff:EW, 0x003000-0x003fff:EW, 0x004000-0x004fff:EW, 0x005000-0x005fff:EW, 
[…]
0x03c000-0x03cfff:EW, 0x03d000-0x03dfff:EW, 0x03e000-0x03efff:EW, 0x03f000-0x03ffff:EW, 0x040000-0x040fff:EERASE FAILED at 0x00040000! Expected=0xff, Read=0x91, failed byte count from 0x00040000-0x00040fff: 0xff0
ERASE FAILED!
Reading current flash chip contents... done. Looking for another erase function.
Trying erase function 1... 0x000000-0x007fff:S, 0x008000-0x00ffff:S, 0x010000-0x017fff:S, 0x018000-0x01ffff:S, 0x020000-0x027fff:EW, 0x028000-0x02ffff:S, 0x030000-0x037fff:S, 0x038000-0x03ffff:S, 0x040000-0x047fff:EW, 0x048000-0x04ffff:EW, 0x050000-0x057fff:EW, 0x058000-0x05ffff:EW, 0x060000-0x067fff:EW, 0x068000-0x06ffff:EW, 0x070000-0x077fff:EW, 0x078000-0x07ffff:EW
Erase/write done.
Verifying flash... VERIFY FAILED at 0x00010000! Expected=0x6b, Read=0x13, failed byte count from 0x00000000-0x0007ffff: 0x101
Your flash chip is in an unknown state.

so the verify output is pretty clearly better (less redundant) now than
before, the erase output is a little worse than before, but not much.

maybe printing "Verification" instead of "ERASE" and "VERIFY" might be
clearer, but the op-dependent parameter is clearly not that important
to warrant keeping it (and complicating the matter that way).
-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner