[flashrom] [PATCH 3/8] ichspi: don't touch the nonexistent(?) BBAR register on ICH8

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Sat Sep 17 23:22:47 CEST 2011


On Sat, 17 Sep 2011 21:39:35 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> Am 17.09.2011 21:22 schrieb Stefan Tauner:
> > On Sat, 17 Sep 2011 16:00:21 +0200
> > Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
> >
>
> I thought we already print that we're trying to set BBAR. But even if
> not, is there any benefit of such a message, i.e. would it help with
> debugging? IMHO the success case is completely uninteresting. If
> anything, we want to make errors more verbose and include the failing
> address.

i dont think we print that, at least i can't see it, but you are
probably right. i have dropped it and added more info in the case of
errors.
thanks for the review/discussion! committed in r1445.

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list